Introduce entropy calculation in fingerprints, benchmark CI #1680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeHahn
reviewed
Jan 12, 2026
GeorgeHahn
reviewed
Jan 12, 2026
|
|
||
| /// Compute Shannon entropy (bits per byte) of a byte sequence. | ||
| #[allow(clippy::cast_precision_loss)] | ||
| fn shannon_entropy(data: &[u8]) -> f64 { |
Contributor
There was a problem hiding this comment.
This looks worth a couple of tests
GeorgeHahn
reviewed
Jan 12, 2026
GeorgeHahn
approved these changes
Jan 12, 2026
Introduced Shannon entropy calculation into the fingerprint mechanism, answering the question of how much entropy our payloads have in them. My pitch is that we should never decrease entropy but that might be naive. At least now we'll know which direction things move in. Also added fingerprints for syslog and splunk_hek. Add CI to our micro-benchmark suite to make sure it doesn't accumulate compilation errors as lading's internal API changes. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
fix-bench-compile
branch
from
c6d8fa4 to
708ad35
Compare
goxberry
reviewed
Jan 12, 2026
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
goxberry
approved these changes
Jan 12, 2026
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduced Shannon entropy calculation into the fingerprint mechanism, answering the question of how much entropy our payloads have in them. My pitch is that we should never decrease entropy but that might be naive. At least now we'll know which direction things move in. Also added fingerprints for syslog and splunk_hek.
Add CI to our micro-benchmark suite to make sure it doesn't accumulate compilation errors as lading's internal API changes.